Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to ignore docker cloud containers #1108

Closed
wants to merge 2 commits into from

Conversation

CharlyF
Copy link
Contributor

@CharlyF CharlyF commented Feb 9, 2018

What does this PR do?

Adds the option to ignore the docker cloud containers.
Also change the logic to not ignore the excluded containers in the metrics:

  • docker.containers.running
  • docker.containers.running.total
  • docker.containers.stopped
  • docker.containers.stopped.total

Motivation

Community request.

Testing Guidelines

  • Launched a stack with the agent and verified that uncommenting this option ignores the tags.
  • Updated tests: containers running and stopped metrics are not collected if they contain an excluded tag.

Versioning

  • Bumped the check version in manifest.json
  • Bumped the check version in datadog_checks/{integration}/__init__.py
  • Updated CHANGELOG.md. Please use Unreleased as the date in the title
    for the new section.
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

Tied to DataDog/dd-agent#3666

@CharlyF CharlyF force-pushed the charly/dockercloud_ignore_containers branch from 2d38569 to 5c3e1c6 Compare February 9, 2018 01:22
@stale
Copy link

stale bot commented Apr 10, 2018

This PR has been automatically marked as stale because it has not had activity in the last 60 days. Note that the PR will not be automatically closed, but this notification will remind us to investigate why there's been inactivity. Thank you for participating in the Datadog open source community.

@stale stale bot added the stale label Apr 10, 2018
@stale stale bot removed the stale label May 18, 2018
@stale
Copy link

stale bot commented Jun 25, 2018

This issue has been automatically marked as stale because it has not had activity in the last 30 days. Note that the issue will not be automatically closed, but this notification will remind us to investigate why there's been inactivity. Thank you for participating in the Datadog open source community.

@stale stale bot added the stale label Jun 25, 2018
@masci
Copy link
Contributor

masci commented Jul 6, 2018

Closing for lack of activity, feel free to reopen at your best convenience.

@masci masci closed this Jul 6, 2018
@CharlyF CharlyF deleted the charly/dockercloud_ignore_containers branch January 3, 2019 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants