Skip to content

Commit

Permalink
Rename assert_extend_generic_entity_sensor to match profile name
Browse files Browse the repository at this point in the history
  • Loading branch information
AlexandreYang committed Aug 2, 2023
1 parent 7041ddb commit 3c2b6a8
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from ..test_e2e_core_metadata import assert_device_metadata
from .utils import (
assert_common_metrics,
assert_extend_entity_sensor,
assert_extend_generic_entity_sensor,
create_e2e_core_test_config,
get_device_ip_from_config,
)
Expand All @@ -32,7 +32,7 @@ def test_e2e_profile__generic_entity_sensor(dd_agent_check):

# --- TEST METRICS ---
assert_common_metrics(aggregator, common_tags)
assert_extend_entity_sensor(aggregator, common_tags)
assert_extend_generic_entity_sensor(aggregator, common_tags)

aggregator.assert_all_metrics_covered()

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from ..test_e2e_core_metadata import assert_device_metadata
from .utils import (
assert_common_metrics,
assert_extend_entity_sensor,
assert_extend_generic_entity_sensor,
assert_extend_generic_if,
create_e2e_core_test_config,
get_device_ip_from_config,
Expand All @@ -33,7 +33,7 @@ def test_e2e_profile_extreme_switching(dd_agent_check):

# --- TEST EXTENDED METRICS ---
assert_extend_generic_if(aggregator, common_tags)
assert_extend_entity_sensor(aggregator, common_tags)
assert_extend_generic_entity_sensor(aggregator, common_tags)

# --- TEST METRICS ---
assert_common_metrics(aggregator, common_tags)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from ..test_e2e_core_metadata import assert_device_metadata
from .utils import (
assert_common_metrics,
assert_extend_entity_sensor,
assert_extend_generic_entity_sensor,
assert_extend_generic_if,
assert_extend_generic_ucd,
create_e2e_core_test_config,
Expand All @@ -35,7 +35,7 @@ def test_e2e_profile_nvidia_cumulus_linux_switch(dd_agent_check):
# --- TEST EXTENDED METRICS ---
assert_extend_generic_if(aggregator, common_tags)
assert_extend_generic_ucd(aggregator, common_tags)
assert_extend_entity_sensor(aggregator, common_tags)
assert_extend_generic_entity_sensor(aggregator, common_tags)

# --- TEST METRICS ---
assert_common_metrics(aggregator, common_tags)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from ..test_e2e_core_metadata import assert_device_metadata
from .utils import (
assert_common_metrics,
assert_extend_entity_sensor,
assert_extend_generic_entity_sensor,
assert_extend_generic_host_resources,
assert_extend_generic_if,
create_e2e_core_test_config,
Expand All @@ -35,7 +35,7 @@ def test_e2e_profile_nvidia_mellanox_switchx(dd_agent_check):
# --- TEST METRICS ---
assert_common_metrics(aggregator, common_tags)
assert_extend_generic_if(aggregator, common_tags)
assert_extend_entity_sensor(aggregator, common_tags)
assert_extend_generic_entity_sensor(aggregator, common_tags)
assert_extend_generic_host_resources(aggregator, common_tags)
aggregator.assert_all_metrics_covered()

Expand Down
2 changes: 1 addition & 1 deletion snmp/tests/test_e2e_core_profiles/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ def assert_extend_generic_host_resources(aggregator, common_tags):
assert_extend_generic_host_resources_base(aggregator, common_tags)


def assert_extend_entity_sensor(aggregator, common_tags):
def assert_extend_generic_entity_sensor(aggregator, common_tags):
# fmt: off
"""Add the following to the snmprec
1.3.6.1.2.1.99.1.1.1.1.8|2|9
Expand Down

0 comments on commit 3c2b6a8

Please sign in to comment.