-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish images based on ghcr.io/datadog/images-rb/engines/ruby
with node and npm installed
#28
Comments
I supposed the reason those applications require Would it be feasible that we made those application as API server which does not require |
yes
The exact purpose of those apps is to simulate what would be ou customer rails HTTP app. Is it possible to have the a rails app without node ? |
I believe so, as only Rails 6.0 and Rails 6.1 seems to use Node and npm. As to why, I'm not sure, but these weblogs needs a lot of cleaning (which I plan to do during the next code freeze) |
Yes, you can provide dd-trace-rb master % docker run --rm -it ruby:3.3 bash
root@7770bbb62624:/# gem -v
3.5.22
root@7770bbb62624:/# gem exec -g rails rails new weblog --api --minimal -GMOCAJT Even with this minimal setup, it still contains lots unnecessary parts can be removed for system tests scenarios |
Ah, i understand now your first comment. Yes, it would definitly be better |
Asset management pipeline via |
DataDog/system-tests uses
ghcr.io/datadog/images-rb/engines/ruby
images as base images to build weblog images.To build them,
node
andnpm
are required, and are installed withapt
. With those deps pre-installed in a base image, not only the build step will be faster, but we won't need any call toapt
, reducing the flake probability of the build step.The text was updated successfully, but these errors were encountered: