Skip to content

Commit

Permalink
Rename attributes to better reflect the impact and add godoc for comp…
Browse files Browse the repository at this point in the history
…uteResourceChange
  • Loading branch information
valerian-roche committed Feb 16, 2024
1 parent 81b2834 commit 3094890
Show file tree
Hide file tree
Showing 4 changed files with 155 additions and 173 deletions.
6 changes: 0 additions & 6 deletions pkg/cache/v3/cache.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,6 @@ type Subscription interface {
// This considers subtleties related to the current migration of wildcard definitions within the protocol.
// More details on the behavior of wildcard are present at https://www.envoyproxy.io/docs/envoy/latest/api-docs/xds_protocol#how-the-client-specifies-what-resources-to-return
IsWildcard() bool

// WatchesResources returns whether at least one of the resources provided is currently being watched by the subscription.
// It is currently only applicable to delta-xds.
// If the request is wildcard, it will always return true,
// otherwise it will compare the provided resources to the list of resources currently subscribed
WatchesResources(resourceNames map[string]struct{}) bool
}

// ConfigWatcher requests watches for configuration resources by a node, last
Expand Down
Loading

0 comments on commit 3094890

Please sign in to comment.