Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain the Java AWS SDK payload tagging env vars #26350

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

ygree
Copy link
Contributor

@ygree ygree commented Nov 18, 2024

What does this PR do? What is the motivation?

documents new env vars and links to guide

Merge instructions

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@ygree ygree self-assigned this Nov 18, 2024
@ygree ygree requested a review from a team as a code owner November 18, 2024 23:17
@ygree
Copy link
Contributor Author

ygree commented Nov 18, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 18, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-18 23:18:13 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2024-11-18 23:43:32 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in master is 30m.


2024-11-18 23:47:30 UTCMergeQueue: This merge request was updated

This PR is rejected because it was updated

Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

Copy link
Contributor

@hestonhoffman hestonhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ygree
Copy link
Contributor Author

ygree commented Nov 19, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 19, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-19 17:41:15 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2024-11-19 17:58:32 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in master is 30m.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants