[DOCS-9537] Add manual steps for nginx browser RUM #26323
Conversation
Preview links (active after the
|
Co-authored-by: Heston Hoffman <[email protected]>
Co-authored-by: Heston Hoffman <[email protected]>
|
/merge |
Devflow running:
|
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
|
/merge -c |
dd-devflow
bot
added
mergequeue-status: removed
and removed
mergequeue-status: in_progress
labels
| - Auto-Instrumentation does not inject into encrypted requests served by NGINX or IIS related to TLS. | ||
| - (NGINX only) Auto-Instrumentation does not inject encrypted requests served by the NGINX web server. |
There was a problem hiding this comment.
💬 suggestion: Those two lines are telling the same thing, no?
| - Auto-Instrumentation does not inject into encrypted requests served by NGINX or IIS related to TLS. | |
| - (NGINX only) Auto-Instrumentation does not inject encrypted requests served by the NGINX web server. | |
| - Auto-Instrumentation does not inject into encrypted requests served by NGINX or IIS related to TLS. |
There was a problem hiding this comment.
Also, that's not entirely true. Currently, it's not possible to inject in HTML pages **proxied **by the web-server. May I suggest this instead:
- End-to-End Encryption by upstream server: If NGINX is acting as a proxy and the upstream server has end-to-end encryption (like TLS) enabled. The module can not inject RUM. Ensure the web server is setup for TLS origination.
There was a problem hiding this comment.
@dmehala Should I add "or IIS" as the original statement does, or does this only apply to NGINX?
There was a problem hiding this comment.
@dmehala I pushed an update - please check.
| error_log <file> info; | ||
| ``` | ||
|
|
||
| [1]: https://app.datadoghq.com/rum/list |
There was a problem hiding this comment.
💬 suggestion: make this link dependent to the selected region
There was a problem hiding this comment.
Hi @BenoitZugmeyer, as far as I know, this already happens automatically. Let me know if you find something different.
|
|
||
| {{% /collapse-content %}} | ||
|
|
||
| {{% collapse-content title="Manual instrumentation" level="h5" %}} |
There was a problem hiding this comment.
💭 thought: it's a bit confusing to talk about "Manual instrumentation" on a page called "Auto instrumentation". Maybe we should have another wording, like: Using the installer and Manual configuration
There was a problem hiding this comment.
Finally! Thank you @BenoitZugmeyer
There was a problem hiding this comment.
Few comments there and there. It's getting increasingly confusing from the customer POV. The title mentions "RUM Browser Monitoring Server-Side (Auto) Instrumentation", some part of the doc says "Auto-instrumentation" and "Manual-instrumentation".
We committed to call the solution "Auto-Instrumentation". It worth to revisit the doc with the definitive naming.
Co-authored-by: Benoît <[email protected]> Co-authored-by: Damien Mehala <[email protected]>
What does this PR do? What is the motivation?
Merge instructions
Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the
<yourname>/descriptionnaming convention) and then add the following PR comment:Additional notes
Needs PM/eng review before merging.