Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RUM 6352] Add documentation for set view name #26025

Merged
merged 5 commits into from
Nov 19, 2024
Merged

[RUM 6352] Add documentation for set view name #26025

merged 5 commits into from
Nov 19, 2024

Conversation

RomanGaignault
Copy link
Contributor

@RomanGaignault RomanGaignault commented Oct 31, 2024 •
edited
Loading

What does this PR do? What is the motivation?

Add documentation for custom view specific context with current and new APIs.

Merge instructions

  • Please merge after reviewing

Additional notes

@github-actions GitHub Actions
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@RomanGaignault RomanGaignault changed the title set view name api advanced configuration [RUM 6352] Add documentation for set view name Oct 31, 2024
@RomanGaignault RomanGaignault marked this pull request as ready for review October 31, 2024 10:11
@RomanGaignault RomanGaignault requested review from a team as code owners October 31, 2024 10:11
anediaz
anediaz reviewed Oct 31, 2024
View reviewed changes
content/en/real_user_monitoring/browser/advanced_configuration.md
{{% /tab %}}
{{< /tabs >}}

**Note**: Changing the view name affects the view and its child events from the time the method is called.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise 🎉

@rtrieu
Copy link
Contributor

rtrieu commented Nov 18, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 18, 2024 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2024-11-18 15:49:19 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in master is 30m.

2024-11-18 17:23:36 UTC ❌ MergeQueue: The checks failed on this merge request

Tests failed on this commit a5b4e03:

  • dd-gitlab/link_checks_preview
  • dd-gitlab/build_preview

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • Any question, go check the FAQ.

@rtrieu
Copy link
Contributor

rtrieu commented Nov 19, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 19, 2024 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2024-11-19 14:29:12 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in master is 30m.

2024-11-19 14:29:26 UTC ❌ MergeQueue: This merge request was updated

This PR is rejected because it was updated

@rtrieu
Copy link
Contributor

rtrieu commented Nov 19, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 19, 2024 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2024-11-19 15:05:32 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in master is 30m.

@dd-mergequeue dd-mergequeue bot merged commit b2a0bf7 into master Nov 19, 2024
18 of 22 checks passed
@dd-mergequeue dd-mergequeue bot deleted the romang/RUM-6562-set-view-name-api branch November 19, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neko-dd neko-dd neko-dd approved these changes

@anediaz anediaz anediaz approved these changes

@amortemousque amortemousque amortemousque approved these changes

@BenoitZugmeyer BenoitZugmeyer BenoitZugmeyer approved these changes

Assignees
No one assigned
Labels
mergequeue-status: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RomanGaignault @rtrieu @BenoitZugmeyer @amortemousque @anediaz @neko-dd