Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-8450: Adding Flutter API #25500

Merged
merged 4 commits into from
Oct 1, 2024
Merged

DOCS-8450: Adding Flutter API #25500

merged 4 commits into from
Oct 1, 2024

Conversation

cswatt
Copy link
Contributor

@cswatt cswatt commented Sep 30, 2024

What does this PR do? What is the motivation?

Adds some undocumented things from the Flutter SDK

Merge instructions

  • Please merge after reviewing

Additional notes

@cswatt cswatt requested a review from a team as a code owner September 30, 2024 22:35
Comment on lines 29 to 32
## Automatic view tracking

If you are using Flutter Navigator v2.0, your setup for automatic view tracking differs depending on your routing middleware. See [Flutter Integrated Libraries][18] for instructions on how to integrate with [go_router][8], [AutoRoute][9], and [Beamer][10].

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if this makes more sense below the initialization parameters?


`firstPartyHosts`
: Optional<br/>
**Type**: [String]<br/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Type**: [String]<br/>
**Type**: List<String><br/>

List<String> is going to be more correct than [String] for Dart, though we may need to escape the angled brackets.


`firstPartyHostsWithTracingHeaders`
: Optional<br/>
**Type**: Map<br/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Type**: Map<br/>
**Type**: Map<String, Set<TracingHeaderType>><br/>

cswatt and others added 2 commits October 1, 2024 12:25
@cswatt cswatt merged commit 81b4daa into master Oct 1, 2024
15 checks passed
@cswatt cswatt deleted the cswatt/flutter-apis branch October 1, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants