DEBUG-2334 correctly serialize debugger input payloads #4125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmarchenko
approved these changes
Nov 18, 2024
p-datadog
added
the
dev/internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes serialization of debugger "input" endpoint payloads. The serialization must be to JSON, previously simple stringification was used which is not JSON.
Motivation:
System tests (under development) revealed the issue.
The incorrect behavior also renders DI inoperable in demos.
Change log entry
None
Additional Notes:
How to test the change?
There is no test coverage in the library for this change, however it is covered by system tests that I am currently working on (DataDog/system-tests#3516)