Support stats "ratio_in_yjit" #3991
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When ruby's extended YJIT stats are available (`--yjit-stat`), then
we have access to numerous additional stats.
This adds `:ratio_in_yjit`, which is only present when additional stats
are enabled.
Example:
```
RUBYOPT='--yjit --yjit-stats=quiet' ruby -e '
def foo = "a" * 10
300.times{foo}
puts "ratio_in_yjit: #{::RubyVM::YJIT.runtime_stats[:ratio_in_yjit]}"
'
ratio_in_yjit: 0.9550806290358625
```
Motivation:
This should allow for better understanding of how to tune `--yjit-exec-mem-size`.
From https://github.com/ruby/ruby/blob/ef084cc8f4958c1b6e4ead99136631bef6d8ddba/doc/yjit/yjit.md?plain=1#L213-L223:
> If you start Ruby with `--yjit-stats`, e.g. using an environment variable `RUBYOPT=--yjit-stats`,
> `RubyVM::YJIT.runtime_stats[:ratio_in_yjit]` shows the ratio of YJIT-executed instructions in %.
> Ideally, `ratio_in_yjit` should be as large as 99%, and increasing `--yjit-exec-mem-size` often
> helps improving `ratio_in_yjit`.
How to test the change?:
```
RUBYOPT="--yjit --yjit-stats=quiet" bundle exec rake spec:yjit
bundle exec rake spec:yjit # skipped
```
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3991 +/- ##
==========================================
- Coverage 97.87% 97.85% -0.02%
==========================================
Files 1314 1314
Lines 78652 78667 +15
Branches 3909 3912 +3
==========================================
+ Hits 76978 76980 +2
- Misses 1674 1687 +13 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Missing some other things in this PR (sig updates, CI updates, etc), but gonna go ahead and put the draft up for discussion.
What does this PR do?
When ruby's extended YJIT stats are available (
--yjit-stat), thenwe have access to numerous additional stats.
This adds
:ratio_in_yjit, which is only present when additional statsare enabled.
Example:
Motivation:
This should allow for a better understanding of how to tune
--yjit-exec-mem-size.From https://github.com/ruby/ruby/blob/ef084cc8f4958c1b6e4ead99136631bef6d8ddba/doc/yjit/yjit.md?plain=1#L213-L223:
Additional Notes:
Fwiw, I directly based this on the previous YJIT PRs, which were very helpful here:
ratio_in_yjithas been available sine 3.3.0: https://github.com/ruby/ruby/blob/caf0d2058aa223515897401ff94e11e1c0671ce0/doc/NEWS/NEWS-3.3.0.md?plain=1#L436How to test the change?