[NO-TICKET] Bag of profiler cleanups #3990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm pretty happy with the same refactoring that was applied to the CpuAndWallTimeWorker, so I went ahead and did it for the ThreadContext.
At some point we thought we may expose this as a user setting, but we never did, and we've been running with this setting enabled all the time, so let's just get rid of it.
Prof-correctness has been updated to stop using `_native_is_running?` in DataDog/prof-correctness#42 .
ivoanjo
added
profiling
BenchmarksBenchmark execution time: 2024-10-10 17:00:44 Comparing candidate commit e84e400 in PR branch Found 1 performance improvements and 1 performance regressions! Performance is the same for 21 metrics, 2 unstable metrics. scenario:profiler - Allocations (profiling enabled)
scenario:profiler - sample timeline=false
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3990 +/- ##
==========================================
- Coverage 97.87% 97.86% -0.01%
==========================================
Files 1314 1314
Lines 78652 78636 -16
Branches 3909 3909
==========================================
- Hits 76978 76957 -21
- Misses 1674 1679 +5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR collects the results of a quick round of cleanups I did on the profiler.
I recommend reviewing commit-by-commit.
Motivation:
A few of these were existing TODOs; others I spotted as I was going along.
Additional Notes:
N/A
How to test the change?
We have existing test coverage for the tweaked bits.