Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iast): partial matches on function names should not be patched [backport 2.11] #11017

Open
wants to merge 2 commits into
base: 2.11
Choose a base branch
from

Commits on Oct 14, 2024

  1. fix(iast): partial matches on function names should not be patched (#…

    …11015)
    
    Code Security: This PR fixes an issue where partial matches of the
    functions we want to patch would be patched instead of exact matches
    
    - [x] PR author has checked that all the criteria below are met
    - The PR description includes an overview of the change
    - The PR description articulates the motivation for the change
    - The change includes tests OR the PR description describes a testing
    strategy
    - The PR description notes risks associated with the change, if any
    - Newly-added code is easy to change
    - The change follows the [library release note
    guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
    - The change includes or references documentation updates if necessary
    - Backport labels are set (if
    [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
    
    - [x] Reviewer has checked that all the criteria below are met
    - Title is accurate
    - All changes are related to the pull request's stated goal
    - Avoids breaking
    [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
    changes
    - Testing strategy adequately addresses listed risks
    - Newly-added code is easy to change
    - Release note makes sense to a user of the library
    - If necessary, author has acknowledged and discussed the performance
    implications of this PR as reported in the benchmarks PR comment
    - Backport labels are set in a manner that is consistent with the
    [release branch maintenance
    policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
    
    (cherry picked from commit a72b931)
    gnufede committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    807a7e5 View commit details
    Browse the repository at this point in the history
  2. simplify test, add comment

    gnufede committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    540be7a View commit details
    Browse the repository at this point in the history