Add copy of http.client with debugging #10998
Conversation
|
|
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
| else: | ||
| # Amount is not given (unbounded read) so we must check self.length | ||
| if self.length is None: | ||
| s = self.fp.read() | ||
| else: | ||
| try: | ||
| s = self._safe_read(self.length) | ||
| except IncompleteRead: | ||
| self._close_conn() | ||
| raise | ||
| self.length = 0 | ||
| self._close_conn() # we read everything | ||
| return s |
There was a problem hiding this comment.
⚪ Code Quality Violation
else is not necessary since the if clause has a return (...read more)
If the code in the if branch returns a value, do not have the else branch present.
|
|
||
| self._output(self._encode_request(request)) | ||
|
|
||
| if self._http_vsn == 11: |
There was a problem hiding this comment.
🟠 Code Quality Violation
Found too many nested ifs within this condition (...read more)
Too many nested loops make the code hard to read and understand. Simplify your code by removing nesting levels and separate code in small units.
| # when used as Host header | ||
|
|
||
| if host.find(':') >= 0: | ||
| host_enc = b'[' + host_enc + b']' |
There was a problem hiding this comment.
🟠 Code Quality Violation
use f-string or .format to format strings (...read more)
Concatenation of multiple strings is not efficient and make the code hard to read and understand.
Instead of concatenating multiple strings, use an f-string or a format string.
Learn More
| # 2. the body is a file or iterable, but not a str or bytes-like | ||
| # 3. Transfer-Encoding has NOT been explicitly set by the caller | ||
|
|
||
| if 'content-length' not in header_names: |
There was a problem hiding this comment.
🟠 Code Quality Violation
Found too many nested ifs within this condition (...read more)
Too many nested loops make the code hard to read and understand. Simplify your code by removing nesting levels and separate code in small units.
| # Save the method for use later in the response phase | ||
| self._method = method | ||
|
|
||
| url = url or '/' |
There was a problem hiding this comment.
🟠 Code Quality Violation
variable name is the same as a function parameter (...read more)
A function parameter should only be read and not be modified. If your intent is to modify the value of the parameter, return the value in the function and handle the new value in the caller of the function.
|
|
||
| class LineTooLong(HTTPException): | ||
| def __init__(self, line_type): | ||
| HTTPException.__init__(self, "got more than %d bytes when reading %s" |
There was a problem hiding this comment.
🟠 Code Quality Violation
| HTTPException.__init__(self, "got more than %d bytes when reading %s" | |
| super().__init__(self, "got more than %d bytes when reading %s" |
should call parent using super() (...read more)
Calling the parent constructor should be done by calling super(), not by calling the parent object directly.
| except: | ||
| response.close() | ||
| raise |
There was a problem hiding this comment.
🟠 Code Quality Violation
no bare except (...read more)
Avoid bare except. Try to always use specialized exception names in except blocks.
| raise ValueError('Invalid header value %r' % (values[i],)) | ||
|
|
||
| value = b'\r\n\t'.join(values) | ||
| header = header + b': ' + value |
There was a problem hiding this comment.
🟠 Code Quality Violation
variable name is the same as a function parameter (...read more)
A function parameter should only be read and not be modified. If your intent is to modify the value of the parameter, return the value in the function and handle the new value in the caller of the function.
| occurrences are returned. Case is not important in the header name. | ||
|
|
||
| """ | ||
| name = name.lower() + ':' |
There was a problem hiding this comment.
🟠 Code Quality Violation
variable name is the same as a function parameter (...read more)
A function parameter should only be read and not be modified. If your intent is to modify the value of the parameter, return the value in the function and handle the new value in the caller of the function.
| mv = memoryview(body) | ||
| return mv.nbytes | ||
| except TypeError: | ||
| pass |
There was a problem hiding this comment.
🔴 Code Quality Violation
silent exception (...read more)
Using the pass statement in an exception block ignores the exception. Exceptions should never be ignored. Instead, the user must add code to notify an exception occurred and attempt to handle it or recover from it.
BenchmarksBenchmark execution time: 2024-10-10 20:05:54 Comparing candidate commit 611e472 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 373 metrics, 51 unstable metrics. |
| else: | ||
| return ', '.join(headers) |
There was a problem hiding this comment.
⚪ Code Quality Violation
else is not necessary since the if clause has a return (...read more)
If the code in the if branch returns a value, do not have the else branch present.
| try: | ||
| import ssl | ||
| except ImportError: | ||
| pass |
There was a problem hiding this comment.
🔴 Code Quality Violation
silent exception (...read more)
Using the pass statement in an exception block ignores the exception. Exceptions should never be ignored. Instead, the user must add code to notify an exception occurred and attempt to handle it or recover from it.
| else: | ||
| return None |
There was a problem hiding this comment.
⚪ Code Quality Violation
else is not necessary since the if clause has a return (...read more)
If the code in the if branch returns a value, do not have the else branch present.
This is part of the investigation of the
IncompleteReadissue in dogweb. It's not meant to be merged, just to be installed temporarily in the ITR shadow job in dogweb staging.Checklist
Reviewer Checklist