Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add tests for config service name override #10968

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

quinna-h
Copy link
Contributor

@quinna-h quinna-h commented Oct 7, 2024

  • use int_service rather than pin.service when appropriate
  • in places where we state (in documentation) that we support service name override with config, we should test this so we know if this functionality breaks

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Oct 7, 2024

CODEOWNERS have been resolved as:

ddtrace/contrib/internal/cassandra/patch.py                             @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/cassandra/session.py                           @DataDog/apm-core-python @DataDog/apm-idm-python
ddtrace/contrib/internal/tornado/template.py                            @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/mysqldb/test_mysqldb.py                                   @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/psycopg/test_psycopg.py                                   @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/pynamodb/test_pynamodb.py                                 @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/pyodbc/test_pyodbc.py                                     @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/redis/test_redis.py                                       @DataDog/apm-core-python @DataDog/apm-idm-python

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Oct 7, 2024

Datadog Report

Branch report: quinna/internal-pinning-service
Commit report: 150d539
Test service: dd-trace-py

✅ 0 Failed, 592 Passed, 604 Skipped, 19m 40.46s Total duration (15m 12.2s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Oct 7, 2024

Benchmarks

Benchmark execution time: 2024-10-07 21:57:44

Comparing candidate commit 33a12e9 in PR branch quinna/internal-pinning-service with baseline commit b380f21 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 216 metrics, 2 unstable metrics.

@quinna-h quinna-h changed the title chore: use internal service method instead of pin.service for internal modules chore: add tests for config service name override Oct 7, 2024
@quinna-h quinna-h added the changelog/no-changelog A changelog entry is not required for this PR. label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant