Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(di): better support for builtin collections #10967

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

P403n1x87
Copy link
Contributor

@P403n1x87 P403n1x87 commented Oct 7, 2024

We improve the support for the serialisation of some builtin collection types when rendering template messages.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@P403n1x87 P403n1x87 added changelog/no-changelog A changelog entry is not required for this PR. Dynamic Instrumentation Dynamic Instrumentation/Live Debugger labels Oct 7, 2024
@P403n1x87 P403n1x87 self-assigned this Oct 7, 2024
@P403n1x87 P403n1x87 requested a review from a team as a code owner October 7, 2024 16:05
@P403n1x87 P403n1x87 enabled auto-merge (squash) October 7, 2024 16:05
Copy link
Contributor

github-actions bot commented Oct 7, 2024

CODEOWNERS have been resolved as:

ddtrace/debugging/_signal/utils.py                                      @DataDog/debugger-python
tests/debugging/test_encoding.py                                        @DataDog/debugger-python

@pr-commenter
Copy link

pr-commenter bot commented Oct 7, 2024

Benchmarks

Benchmark execution time: 2024-10-08 10:34:35

Comparing candidate commit 8377d07 in PR branch chore/di-better-support-for-builtin-collections with baseline commit f757fbf in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 214 metrics, 2 unstable metrics.

We improve the support for the serialisation of some builtin collection
types when rendering template messages.
@P403n1x87 P403n1x87 force-pushed the chore/di-better-support-for-builtin-collections branch from 861652e to 131f333 Compare October 7, 2024 21:06
@P403n1x87 P403n1x87 requested a review from shatzi October 10, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. Dynamic Instrumentation Dynamic Instrumentation/Live Debugger
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants