fix(botocore): bedrock cross-region inference model name does not throw [backport 2.14] #10966
+15
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 80a3ee8 from #10949 to 2.14.
What does this PR do?
Fixes #10772
Model IDs with cross-region inference would throw because we assumed
modelID
would only have theprovider
andmodel_name
, when it could have the region as well. This would result in:We are not tagging that cross-region inference in this PR, just resolving the error.
Testing
To test this change, a singular
anthropic_message
test case and corresponding cassette was modified. This had an unfortunate side effect of affecting an LLMObs test as well. I can add a different test instead, but I believe that would require an additional 60+ line cassette which isn't totally needed, so I opted for this instead.Checklist
Reviewer Checklist