Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block remote config signals during ftp functions #2957

Open
wants to merge 1 commit into
base: bob/live-debugger-dedup
Choose a base branch
from

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Nov 15, 2024

These are sensitive to EINTR, so block the signal during their execution.

Fixes #2952.

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.52%. Comparing base (d1a8696) to head (19dcc2f).
Report is 1 commits behind head on bob/live-debugger-dedup.

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                     @@
##             bob/live-debugger-dedup    #2957   +/-   ##
==========================================================
  Coverage                      66.52%   66.52%           
  Complexity                      2739     2739           
==========================================================
  Files                            109      109           
  Lines                          10831    10831           
==========================================================
  Hits                            7205     7205           
  Misses                          3626     3626           
Flag Coverage Δ
tracer-php 66.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1a8696...19dcc2f. Read the comment docs.

@pr-commenter
Copy link

pr-commenter bot commented Nov 15, 2024

Benchmarks [ tracer ]

Benchmark execution time: 2024-11-15 22:15:46

Comparing candidate commit 19dcc2f in PR branch bob/block-ftp-sigprocmask with baseline commit d1a8696 in branch bob/live-debugger-dedup.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 177 metrics, 0 unstable metrics.

scenario:TraceFlushBench/benchFlushTrace

  • 🟩 execution_time [-1000.000ns; -1000.000ns] or [-50.000%; -50.000%]

These are sensitive to EINTR, so block the signal during their execution.

Fixes #2952.

Signed-off-by: Bob Weinand <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants