Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[loader] Fix crash when the loader is loaded multiple times #2954

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

iamluc
Copy link
Contributor

@iamluc iamluc commented Nov 15, 2024

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@iamluc iamluc requested a review from a team as a code owner November 15, 2024 13:21
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.74%. Comparing base (02fe693) to head (6b2a17c).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2954   +/-   ##
=========================================
  Coverage     70.74%   70.74%           
  Complexity     2741     2741           
=========================================
  Files           110      110           
  Lines         10833    10833           
=========================================
  Hits           7664     7664           
  Misses         3169     3169           
Flag Coverage Δ
tracer-php 70.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02fe693...6b2a17c. Read the comment docs.

Copy link
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :-)

@iamluc iamluc merged commit b3c078a into master Nov 15, 2024
653 of 689 checks passed
@iamluc iamluc deleted the luc/fix-loader-loaded-multiple-times branch November 15, 2024 14:44
@github-actions github-actions bot added this to the 1.5.0 milestone Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants