-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(profiling) add stream_select()
-type functions to timeline
#2943
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2943 +/- ##
============================================
+ Coverage 72.46% 73.97% +1.51%
Complexity 2527 2527
============================================
Files 135 108 -27
Lines 14402 10360 -4042
Branches 991 0 -991
============================================
- Hits 10436 7664 -2772
+ Misses 3422 2696 -726
+ Partials 544 0 -544
Flags with carried forward coverage won't be shown. Click here to find out more. see 27 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Benchmarks [ profiler ]Benchmark execution time: 2024-11-13 14:53:24 Comparing candidate commit 31a763d in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 9 unstable metrics. |
773099a
to
51f183b
Compare
select()
-type functions to timelinestream_select()
-type functions to timeline
51f183b
to
92ee98c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First glance looks good, will look a bit more later!
44e282b
to
31a763d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any other feedback. Looks good to me.
Description
This will wrap functions that are used to wait on blocking I/O, like
stream_select()
and others. It also moves thefrankenphp_handle_request()
to theidle
visualisation because technically it is waiting on I/O, but it is used to wait for the next request, just likeRSHUTDOWN
->RINIT
so it should share the same vis.In async PHP (using ReactPHP, AMPHP or others), spending time in a
stream_select()
-type function call means the event-loop is idle.PPROF-10884
AMPHP event loop:
ext-parallel
's\parallel\Events::poll()
method:Reviewer checklist