-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add tooling to generate stubs for the Public PHP API #2933
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2933 +/- ##
=============================================
- Coverage 82.10% 70.32% -11.78%
- Complexity 2527 2739 +212
=============================================
Files 108 136 +28
Lines 10359 14822 +4463
Branches 0 989 +989
=============================================
+ Hits 8505 10424 +1919
- Misses 1854 3855 +2001
- Partials 0 543 +543
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 35 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Benchmarks [ tracer ]Benchmark execution time: 2024-11-14 09:05:46 Comparing candidate commit 2a70431 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 178 metrics, 0 unstable metrics. |
92852e5
to
4223bc3
Compare
Could you please rename the |
Also, can you please put the generated merged stub file in the $packages_build_dir directly rather than inside the .tar.gz? That way it'll also appear in the artifacts directly, for easy download directly from the artifacts page. |
Somehow the string sequence
becomes
(note the 1b in the hex output) |
Co-authored-by: Bob Weinand <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks Alexandre :-)
Description
AIDM-460 & AIDM-463
This PR adds simple tooling to add one stub file (
src/ddtrace_php_api.stubs.php
) for all the Public PHP API files (pulled from the files declared in the bridge).This allows us to generate a stub file locally using
make generate_stubs
(PHP 8+).Additionally, all stubs files (there are four) will be merged together and added to the final artifact as
datadog-tracer.stubs.php
.The
generated files up-to-date
job will regenerate PHP stubs and compare them on each commit, failing if there is a difference.Reviewer checklist