-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(profiling): bump to Rust 1.76 #2876
Conversation
The CI images were previously bumped to Rust 1.76.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2876 +/- ##
============================================
+ Coverage 78.23% 80.91% +2.68%
Complexity 2526 2526
============================================
Files 173 146 -27
Lines 18742 14711 -4031
Branches 981 0 -981
============================================
- Hits 14662 11903 -2759
+ Misses 3540 2808 -732
+ Partials 540 0 -540
Flags with carried forward coverage won't be shown. Click here to find out more. see 28 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Benchmarks [ profiler ]Benchmark execution time: 2024-10-10 12:00:04 Comparing candidate commit 40a8587 in PR branch Found 5 performance improvements and 0 performance regressions! Performance is the same for 22 metrics, 9 unstable metrics. scenario:walk_stack/50
scenario:walk_stack/99
scenario:walk_stack_instructions/1
scenario:walk_stack_instructions/50
scenario:walk_stack_instructions/99
|
Looks like this break build on RHEL and clones (rust 1.75) see #2882 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Bumps the profiler to Rust 1.76 from 1.71. The CI images were previously bumped to Rust 1.76 because of a miscompilation issue.
Reviewer checklist