-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: shrink size of Rust artifacts #2696
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2696 +/- ##
============================================
+ Coverage 77.77% 79.32% +1.55%
Complexity 2223 2223
============================================
Files 226 200 -26
Lines 26386 22369 -4017
Branches 988 0 -988
============================================
- Hits 20522 17745 -2777
+ Misses 5338 4624 -714
+ Partials 526 0 -526
Flags with carried forward coverage won't be shown. Click here to find out more. see 26 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
This does not do panic=abort because to be effective, you also need to rebuild std, and _that_ means rebuilding images and also installing from rustup (because the packages we are using do not include std sources). But this will still shrink the size a fair bit.
b578570
to
76dd2bf
Compare
Difference between the commit on master and this branch:
Roughly 15% savings. |
BenchmarksBenchmark execution time: 2024-06-07 03:46:29 Comparing candidate commit 76dd2bf in PR branch Found 2 performance improvements and 1 performance regressions! Performance is the same for 26 metrics, 7 unstable metrics. scenario:php-profiler-timeline-memory-with-profiler-and-timeline
scenario:walk_stack/1
|
This does not do panic=abort because to be effective, you also need to rebuild std, and _that_ means rebuilding images and also installing from rustup (because the packages we are using do not include std sources). But this will still shrink the size a fair bit.
PROF-9904
Description
This is an attempt to shrink artifacts, but unlike #2601, this does not do
panic=abort
. Forpanic=abort
to be really effective, you also need to rebuild std from source. That means rebuilding images and also installing Rust from rustup (because the packages we are using do not include std sources). We had issues with CI last time we tried it. We played whack-a-mole for a while, but since the issues just kept going and we wanted to release 1.0.0beta1, we decide to revert back.But this PR without
panic=abort
will still shrink the size a fair bit, so it's worth splitting out. I wouldn't go so far as saying that it will fix the size issue reported in PR #2599, but it helps.Reviewer checklist