improve logging of spans in trace log level #5074
Merged
+46
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improve logging of spans in trace log level.
Motivation
When logging spans using
util.inspect
and by extensionconsole.log
, a lot of references to external objects that are not useful are displayed because of strong references to them. Hiding them removes that noise and makes the output easier to use.Additional Notes
The
Span
class was strongly referencing its own store, which I also changed so that it holds the handle instead. This will no longer be needed when we add an actual span store instead of a generic store that holds everything.