Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] Add TODO comment #5054

Merged
merged 1 commit into from
Jan 2, 2025
Merged

[DI] Add TODO comment #5054

merged 1 commit into from
Jan 2, 2025

Conversation

watson
Copy link
Collaborator

@watson watson commented Dec 20, 2024

What does this PR do?

Adds a TODO comment some code added in #5035.

Motivation

Just so I don't forget.

Copy link
Collaborator Author

watson commented Dec 20, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

Overall package size

Self size: 8.41 MB
Deduped: 94.88 MB
No deduping: 95.39 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.3.0 | 29.43 MB | 29.43 MB | | @datadog/native-appsec | 8.3.0 | 19.37 MB | 19.38 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.6.1 | 2.59 MB | 2.73 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.80%. Comparing base (4f87373) to head (cb63abc).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5054      +/-   ##
==========================================
- Coverage   88.75%   87.80%   -0.95%     
==========================================
  Files          12      121     +109     
  Lines         480     4364    +3884     
==========================================
+ Hits          426     3832    +3406     
- Misses         54      532     +478     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Dec 20, 2024

Benchmarks

Benchmark execution time: 2024-12-20 19:07:38

Comparing candidate commit cb63abc in PR branch watson/DEBUG-2613/add-todo with baseline commit 3798033 in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 777 metrics, 20 unstable metrics.

scenario:plugin-graphql-with-async-hooks-22

  • 🟥 max_rss_usage [+111.439MB; +126.213MB] or [+20.932%; +23.707%]

@watson watson enabled auto-merge (squash) December 21, 2024 07:40
@watson watson merged commit 8981beb into master Jan 2, 2025
305 of 306 checks passed
@watson watson deleted the watson/DEBUG-2613/add-todo branch January 2, 2025 10:02
rochdev pushed a commit that referenced this pull request Jan 8, 2025
@rochdev rochdev mentioned this pull request Jan 8, 2025
rochdev pushed a commit that referenced this pull request Jan 8, 2025
@rochdev rochdev mentioned this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants