Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filesystem events to the timeline #4965

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Conversation

szegedi
Copy link
Contributor

@szegedi szegedi commented Dec 3, 2024

What does this PR do?

Adds filesystem events to the timeline.

Motivation

Users can have even more information in the timeline. Additionally, filesystem operations use the same worker thread pool that DNS operations use, so we have a better insight into its use (for reporting of oversubscription.)

Additional Notes

This is implemented by listening to our apm:fs:operation:* diagnostic channels. I took care to not gather information for *Sync calls as they show up as blocked stack traces in the main thread anyway. Additionally, we are selective about what parameters of methods we gather (not gathering strings when they can be data.)

Jira: PROF-10998

Copy link

github-actions bot commented Dec 3, 2024

Overall package size

Self size: 8.31 MB
Deduped: 94.78 MB
No deduping: 95.29 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.3.0 | 29.43 MB | 29.43 MB | | @datadog/native-appsec | 8.3.0 | 19.37 MB | 19.38 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.6.1 | 2.59 MB | 2.73 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@szegedi szegedi force-pushed the szegedi/add-filesystem-events branch from 49c33d5 to 3792b2a Compare December 3, 2024 14:33
@pr-commenter
Copy link

pr-commenter bot commented Dec 3, 2024

Benchmarks

Benchmark execution time: 2024-12-18 14:22:29

Comparing candidate commit 26e0a4c in PR branch szegedi/add-filesystem-events with baseline commit 28bca83 in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 780 metrics, 17 unstable metrics.

scenario:plugin-graphql-with-async-hooks-22

  • 🟥 max_rss_usage [+102.310MB; +119.190MB] or [+18.942%; +22.067%]

Base automatically changed from szegedi/sample-timeline-events to master December 3, 2024 15:16
@szegedi szegedi force-pushed the szegedi/add-filesystem-events branch 2 times, most recently from b308d8e to 154ba7d Compare December 18, 2024 14:04
@szegedi szegedi force-pushed the szegedi/add-filesystem-events branch from 154ba7d to 26e0a4c Compare December 18, 2024 14:12
@szegedi szegedi marked this pull request as ready for review December 18, 2024 14:31
@szegedi szegedi requested review from a team as code owners December 18, 2024 14:31
@szegedi szegedi requested a review from nsavoire December 19, 2024 12:39
@szegedi szegedi merged commit 4e2e716 into master Dec 19, 2024
306 checks passed
@szegedi szegedi deleted the szegedi/add-filesystem-events branch December 19, 2024 17:04
rochdev pushed a commit that referenced this pull request Dec 19, 2024
@rochdev rochdev mentioned this pull request Dec 19, 2024
rochdev pushed a commit that referenced this pull request Dec 19, 2024
@rochdev rochdev mentioned this pull request Dec 19, 2024
rochdev pushed a commit that referenced this pull request Dec 19, 2024
rochdev pushed a commit that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants