Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare support for Dynamic Instrumentation #4492

Merged
merged 40 commits into from
Sep 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
58701b5
Add support for Dynamic Instrumentation
watson Jul 9, 2024
09ddbe9
Fix CODEOWNERS ownership
watson Sep 9, 2024
5911608
Fake agent: Ensure internal state is updated even if emit throws
watson Sep 9, 2024
d1538df
Fix spelling in comments
watson Sep 9, 2024
adc2f7e
Worker thread exit is always unexpected
watson Sep 9, 2024
6c7c65e
Don't send the same probe ack more than once
watson Sep 9, 2024
2088e10
Use correct logger values
watson Sep 9, 2024
ce33087
Add a few TODO's
watson Sep 9, 2024
2309aa3
Researched TODO items
watson Sep 9, 2024
26d2015
Add a few TODOs
watson Sep 9, 2024
f16cb43
Resolve race condition by adding a mutex lock
watson Sep 9, 2024
4acf7e3
Improve integration test assert
watson Sep 9, 2024
be8e193
[test] add test:integration:debugger script
watson Sep 9, 2024
3010102
[ci] add GitHub workflow for running debugger tests
watson Sep 9, 2024
8e15d3c
Use UUID function from Node.js core
watson Sep 10, 2024
93e547a
Just to be sure: log messageerror events
watson Sep 10, 2024
5dfa1f0
Handle multiple probes in parallel
watson Sep 10, 2024
c388f3a
Ensure that mutex lock is released if error is thrown
watson Sep 10, 2024
728196a
Add comment describing race condition
watson Sep 10, 2024
23c3340
Clean up nicely if worker thread exits
watson Sep 10, 2024
7c3c476
Ensure worker thread doesn't inherit NODE_OPTIONS
watson Sep 10, 2024
321c0e7
Ups :D
watson Sep 10, 2024
5c63dcb
Fix license issue for mutexify
watson Sep 10, 2024
7e4fc55
Reduce number of promises created
watson Sep 10, 2024
1bb44eb
Add code comment to clearify intent
watson Sep 10, 2024
7ce866a
Add TODO for later
watson Sep 10, 2024
69b6ff6
Log errors if probe snapshots couldn't be sent
watson Sep 10, 2024
fc7c59a
Fix bug related to custom agent URL
watson Sep 11, 2024
8e2307c
Fix typo
watson Sep 11, 2024
5a7ff5f
Test race condition
watson Sep 11, 2024
e31c302
Code cleanup
watson Sep 12, 2024
a301d11
Remove async code where it's not needed
watson Sep 12, 2024
edce631
Change content of logger.tread_{id/name}
watson Sep 12, 2024
1ad98ab
Set logger.version to the tracer version instead of 2
watson Sep 12, 2024
3e2f0d9
Guard against race condition in tests
watson Sep 12, 2024
5a36956
Fix typo in code
watson Sep 12, 2024
10cea31
Code cleanup
watson Sep 12, 2024
4963955
Roll out own lock function
watson Sep 12, 2024
4f8a99d
Address review comments
watson Sep 13, 2024
51168eb
Merge branch 'master' into watson/DEBUG-2532/di
watson Sep 13, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions .github/workflows/debugger.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
name: Debugger
watson marked this conversation as resolved.
Show resolved Hide resolved

on:
pull_request:
push:
branches: [master]
schedule:
- cron: '0 4 * * *'

concurrency:
group: ${{ github.workflow }}-${{ github.ref || github.run_id }}
cancel-in-progress: true

jobs:
ubuntu:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
watson marked this conversation as resolved.
Show resolved Hide resolved
- uses: ./.github/actions/testagent/start
- uses: ./.github/actions/node/setup
- uses: ./.github/actions/install
- uses: ./.github/actions/node/18
- run: yarn test:debugger:ci
- run: yarn test:integration:debugger
- uses: ./.github/actions/node/20
- run: yarn test:debugger:ci
- run: yarn test:integration:debugger
- uses: ./.github/actions/node/latest
- run: yarn test:debugger:ci
- run: yarn test:integration:debugger
- if: always()
uses: ./.github/actions/testagent/logs
- uses: codecov/codecov-action@v3
watson marked this conversation as resolved.
Show resolved Hide resolved
5 changes: 5 additions & 0 deletions CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

/packages/dd-trace/src/appsec/ @DataDog/asm-js
/packages/dd-trace/test/appsec/ @DataDog/asm-js

/integration-tests/debugger/ @DataDog/dd-trace-js @DataDog/debugger
/packages/dd-trace/src/debugger/ @DataDog/dd-trace-js @DataDog/debugger
/packages/dd-trace/test/debugger/ @DataDog/dd-trace-js @DataDog/debugger

/packages/dd-trace/src/lambda/ @DataDog/serverless-aws
/packages/dd-trace/test/lambda/ @DataDog/serverless-aws

Expand Down
Loading
Loading