-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tracing(aws-sdk): improve sqs dsm tracing experience #4425
Conversation
…context in request complete if no callback is used
Overall package sizeSelf size: 6.72 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
BenchmarksBenchmark execution time: 2024-06-24 15:13:43 Comparing candidate commit 70c2b7f in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 261 metrics, 5 unstable metrics. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4425 +/- ##
===========================================
- Coverage 92.64% 78.99% -13.65%
===========================================
Files 116 249 +133
Lines 4173 10719 +6546
Branches 33 33
===========================================
+ Hits 3866 8468 +4602
- Misses 307 2251 +1944 ☔ View full report in Codecov by Sentry. |
* ensure datadog attributes are received by sqs and set DSM extraction context in request complete if no callback is used
* ensure datadog attributes are received by sqs and set DSM extraction context in request complete if no callback is used
* ensure datadog attributes are received by sqs and set DSM extraction context in request complete if no callback is used
* ensure datadog attributes are received by sqs and set DSM extraction context in request complete if no callback is used
Changes a few small things with AWS SQS Tracing:
receiveMessage
attributes to always return injected_datadog
attributes (used for DSM / APM Trace context propagation)receiveMessage
function was called with a callback. Since we have all the information necessary to extract DSM context without using a callback and do not need any context storing, we can extract the context forawait <receiveMessage>.promise()
call styles.What does this PR do?
Motivation
Plugin Checklist
Additional Notes