Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.42.0 proposal #4418

Closed
wants to merge 11 commits into from
Closed

v4.42.0 proposal #4418

wants to merge 11 commits into from

Conversation

tlhunter
Copy link
Member

@tlhunter tlhunter commented Jun 20, 2024

Looks like most of these failures were present as of the v4.41.0 release: #4395

uurien and others added 11 commits June 20, 2024 11:12

---------

Co-authored-by: Carles Capell <[email protected]>
Co-authored-by: simon-id <[email protected]>
* Fix cassandra tests

* Use cassandra 2.2.4

* Use cassandra 3
* Stack trace collection configuration

* Collect and report stack trace for appsec events

* Handle generate_stack waf action

* Fix linting in config.spec.js

* Add assertion for stack trace tag in meta_struct for express test

* Refactor reportStackTrace and some additional test

* Fix lint

* Additional assert in reportStackTrace test

* Update config

* Rework on stack trace collection

* Callsite line and column as numbers

* Update packages/dd-trace/src/appsec/stack_trace.js

Co-authored-by: Ugaitz Urien <[email protected]>

* Update packages/dd-trace/src/appsec/stack_trace.js

Co-authored-by: Ugaitz Urien <[email protected]>

* Reorder test structure

* Fix linting

* No exploit stack limit when max is set to 0 or below

* Fix filtered and capped frames case

* Fix lint

---------

Co-authored-by: Ugaitz Urien <[email protected]>
* Add JS Hapi macrobenchmark

* Specify dd-trace-js version via DDTRACE_INSTALL_VERSION

* Fix branch name

* Tweak RPS

* Tweak benchmark duration

* Repeatability testing

* Add retries on Gitlab internal system failures, tweak RPS

* Keep only 2 variants for a moment

---------

Co-authored-by: Dmytro Yurchenko <[email protected]>
* DD_APM_TRACING_ENABLED and span _dd.apm.enabled tag

* clean up

* Use MANUAL_KEEP const

* Add _dd.p.appsec tag on standalone ASM events

* Include apmTracingEnabled checks

* Appsec Reporter tests

* Appsec sdk track_event test

* Use numeric value for _dd.p.appsec

* Include appsec standalone config in .ts files

* Clean up null and undefined values

* Remove not needed config properties

* standalone module

* Clean up

* standalone proxy test

* Update packages/dd-trace/test/appsec/iast/vulnerability-reporter.spec.js

Co-authored-by: Ugaitz Urien <[email protected]>

* appsec reporter test

* Use standalone singletone in vulnerability-reporter

* continue applying ratelimiter on appsec standalone events

* Update packages/dd-trace/src/appsec/reporter.js

Co-authored-by: simon-id <[email protected]>

* Add _dd.apm.enabled:0 in root spans with remote parent

* Use a method to add the tag

* Remove apmTracingEnabled config property

* Add _dd.p.appsec tag in trace tags

* Some tests

* Set _dd.apm.enabled in root span

* configure standalone if _tracingInitialized

* Use dd-trace:span:start channel

* Clean up

* use a meta tag

* hasSubscribers check

* test description

* Check span context has tags before using them and check if config has changed

* clean up

* Clean up

* Clean up

* clean up

* Update packages/dd-trace/test/appsec/sdk/track_event.spec.js

Co-authored-by: Ugaitz Urien <[email protected]>

* Update packages/dd-trace/test/appsec/standalone.spec.js

Co-authored-by: Ugaitz Urien <[email protected]>

* protect sample method

* Use assert instead expect

* unsubscribe after test

* suggestions

---------

Co-authored-by: Ugaitz Urien <[email protected]>
Co-authored-by: simon-id <[email protected]>
@tlhunter tlhunter requested a review from a team as a code owner June 20, 2024 18:13
Copy link

Overall package size

Self size: 6.72 MB
Deduped: 61.98 MB
No deduping: 62.26 MB

Dependency sizes

name version self size total size
@datadog/native-appsec 8.0.1 15.59 MB 15.6 MB
@datadog/native-iast-taint-tracking 2.1.0 14.91 MB 14.92 MB
@datadog/pprof 5.3.0 9.85 MB 10.22 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.3.1 2.15 MB 2.24 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.8.0 1.21 MB 1.21 MB
import-in-the-middle 1.8.1 71.67 kB 741.34 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
pprof-format 2.1.0 111.69 kB 111.69 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.4 23.1 kB 23.1 kB
retry 0.13.1 18.85 kB 18.85 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Jun 20, 2024

Benchmarks

Benchmark execution time: 2024-06-20 18:22:51

Comparing candidate commit 1ab1ae6 in PR branch v4.42.0-proposal with baseline commit 3b9c501 in branch v4.x.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 778 metrics, 20 unstable metrics.

@tlhunter tlhunter marked this pull request as draft June 20, 2024 19:18
@tlhunter tlhunter closed this Jul 8, 2024
@tlhunter tlhunter deleted the v4.42.0-proposal branch July 8, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants