-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test-visibility] Add support for vitest #4415
Conversation
Overall package sizeSelf size: 6.76 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4415 +/- ##
===========================================
+ Coverage 63.53% 84.08% +20.54%
===========================================
Files 3 258 +255
Lines 373 11496 +11123
Branches 33 33
===========================================
+ Hits 237 9666 +9429
- Misses 136 1830 +1694 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-06-28 12:27:11 Comparing candidate commit 44ed749 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 260 metrics, 6 unstable metrics. |
@@ -4,7 +4,7 @@ declare const exporters: { | |||
DATADOG: 'datadog', | |||
AGENT_PROXY: 'agent_proxy', | |||
JEST_WORKER: 'jest_worker', | |||
CUCUMBER_WORKER: 'cucumber_worker' | |||
CUCUMBER_WORKER: 'cucumber_worker', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated fix
70c53f1
70c53f1
to
0d60e30
Compare
f006d71
to
37f33e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
vitest
plugin.Motivation
Support users of vitest as this test framework is being used more:
This PR also closes #2366
Plugin Checklist
To be reviewed by language platform
To make an ESM library work with IITM I had to make the following changes:
specifiers
check. I'm not sure if this was the intention ofinternals: true
, as the explanation in the repo is not 100% clear to me.file
parameter of theaddHook
function: https://github.com/DataDog/dd-trace-js/pull/4415/files#diff-0f4756798ec0b2564244375056c78d8ceca75a90a6b6dbc152d5468eb754c618R84. This is needed because the installedvitest
adds hashes to the files: