Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test-visibility] Add support for vitest #4415

Merged
merged 31 commits into from
Jun 28, 2024

Conversation

juan-fernandez
Copy link
Collaborator

@juan-fernandez juan-fernandez commented Jun 19, 2024

What does this PR do?

  • Add vitest plugin.
  • Add e2e tests for vitest.

Motivation

Support users of vitest as this test framework is being used more:

This PR also closes #2366

Plugin Checklist

To be reviewed by language platform

To make an ESM library work with IITM I had to make the following changes:

Installed files by vitest

Copy link

github-actions bot commented Jun 19, 2024

Overall package size

Self size: 6.76 MB
Deduped: 62.02 MB
No deduping: 62.3 MB

Dependency sizes

name version self size total size
@datadog/native-appsec 8.0.1 15.59 MB 15.6 MB
@datadog/native-iast-taint-tracking 2.1.0 14.91 MB 14.92 MB
@datadog/pprof 5.3.0 9.85 MB 10.22 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.3.1 2.15 MB 2.24 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.8.0 1.21 MB 1.21 MB
import-in-the-middle 1.8.1 71.67 kB 741.34 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
pprof-format 2.1.0 111.69 kB 111.69 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.4 23.1 kB 23.1 kB
retry 0.13.1 18.85 kB 18.85 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.08%. Comparing base (67aebc2) to head (b29cfdb).
Report is 7 commits behind head on master.

Current head b29cfdb differs from pull request most recent head 44ed749

Please upload reports for the commit 44ed749 to get more accurate results.

Files Patch % Lines
packages/dd-trace/src/plugins/index.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4415       +/-   ##
===========================================
+ Coverage   63.53%   84.08%   +20.54%     
===========================================
  Files           3      258      +255     
  Lines         373    11496    +11123     
  Branches       33       33               
===========================================
+ Hits          237     9666     +9429     
- Misses        136     1830     +1694     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Jun 19, 2024

Benchmarks

Benchmark execution time: 2024-06-28 12:27:11

Comparing candidate commit 44ed749 in PR branch juan-fernandez/add-vitest-support with baseline commit 98ec9e7 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 260 metrics, 6 unstable metrics.

@@ -4,7 +4,7 @@ declare const exporters: {
DATADOG: 'datadog',
AGENT_PROXY: 'agent_proxy',
JEST_WORKER: 'jest_worker',
CUCUMBER_WORKER: 'cucumber_worker'
CUCUMBER_WORKER: 'cucumber_worker',
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated fix

package.json Outdated Show resolved Hide resolved
@juan-fernandez juan-fernandez changed the title [test-visibility] [wip] Add support for vitest [test-visibility] Add support for vitest Jun 20, 2024
@juan-fernandez juan-fernandez force-pushed the juan-fernandez/add-vitest-support branch from 70c53f1 to 0d60e30 Compare June 27, 2024 15:38
@juan-fernandez juan-fernandez force-pushed the juan-fernandez/add-vitest-support branch from f006d71 to 37f33e7 Compare June 28, 2024 09:10
Copy link
Collaborator

@uurien uurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juan-fernandez juan-fernandez merged commit 5daf54d into master Jun 28, 2024
153 checks passed
@juan-fernandez juan-fernandez deleted the juan-fernandez/add-vitest-support branch June 28, 2024 12:32
This was referenced Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vitest support for CI
6 participants