Update Otel Invalid Telemetry Calculation

[khanayan123]

What does this PR do?

Updates the criteria on which the otel invalid telemetry metric is incremented

Motivation

Update how the invalid telemetry metric is incremented based on Stuart's clarification on the Otel ENV Var RFC

Notes

Tested locally with systems tests under this PR: DataDog/system-tests#2597

[github-actions]

Overall package size

Self size: 6.72 MB
Deduped: 61.98 MB
No deduping: 62.26 MB

Dependency sizes

name	version	self size	total size
@datadog/native-appsec	8.0.1	15.59 MB	15.6 MB
@datadog/native-iast-taint-tracking	2.1.0	14.91 MB	14.92 MB
@datadog/pprof	5.3.0	9.85 MB	10.22 MB
protobufjs	7.2.5	2.77 MB	6.56 MB
@datadog/native-iast-rewriter	2.3.1	2.15 MB	2.24 MB
@opentelemetry/core	1.14.0	872.87 kB	1.47 MB
@datadog/native-metrics	2.0.0	898.77 kB	1.3 MB
@opentelemetry/api	1.8.0	1.21 MB	1.21 MB
import-in-the-middle	1.8.1	71.67 kB	741.34 kB
msgpack-lite	0.1.26	201.16 kB	281.59 kB
opentracing	0.14.7	194.81 kB	194.81 kB
semver	7.5.4	93.4 kB	123.8 kB
pprof-format	2.1.0	111.69 kB	111.69 kB
@datadog/sketches-js	2.1.0	109.9 kB	109.9 kB
lodash.sortby	4.7.0	75.76 kB	75.76 kB
lru-cache	7.14.0	74.95 kB	74.95 kB
ignore	5.2.4	51.22 kB	51.22 kB
int64-buffer	0.1.10	49.18 kB	49.18 kB
shell-quote	1.8.1	44.96 kB	44.96 kB
istanbul-lib-coverage	3.2.0	29.34 kB	29.34 kB
tlhunter-sorted-set	0.1.0	24.94 kB	24.94 kB
limiter	1.1.5	23.17 kB	23.17 kB
dc-polyfill	0.1.4	23.1 kB	23.1 kB
retry	0.13.1	18.85 kB	18.85 kB
jest-docblock	29.7.0	8.99 kB	12.76 kB
crypto-randomuuid	1.0.0	11.18 kB	11.18 kB
path-to-regexp	0.1.7	6.78 kB	6.78 kB
koalas	1.0.2	6.47 kB	6.47 kB
module-details-from-path	1.0.3	4.47 kB	4.47 kB

_{🤖 This report was automatically generated by heaviest-objects-in-the-universe}

[pr-commenter]

Benchmarks

Benchmark execution time: 2024-06-24 20:11:16

Comparing candidate commit 502b03c in PR branch khanayan123/update-otel-invalid-telemetry-calculation with baseline commit e939d31 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 260 metrics, 6 unstable metrics.

[zacharycmontoya]

If I'm understanding this correctly, we're no longer considering this as "invalid" because we don't have a set of recognized values, so that's why the otelInvalid.length went down?

[khanayan123]

Yes precisely, I think that should also be the expected behavior cross tracers.

[zacharycmontoya]

If I'm understanding this correctly, we're incrementing the otelHiding.length in the test because now we consider the OTEL_TRACES_SAMPLER_ARG config as another config that's being overlooked by its corresponding Datadog config, DD_TRACE_SAMPLE_RATE?

[khanayan123]

Yes, since they both map to DD_TRACE_SAMPLE_RATE it makes more sense to increment them as seperate pairs of tags. since a user could have inputted both an invalid OTEL_TRACES_SAMPLER value & and an invalid OTEL_TRACES_SAMPLER_ARG value or either or. This makes it more granular.

[zacharycmontoya]

LGTM

[codecov]

Codecov Report

Attention: Patch coverage is 89.47368% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.37%. Comparing base (b1f1f85) to head (2d6993f).
Report is 11 commits behind head on master.

❗ Current head 2d6993f differs from pull request most recent head 502b03c

Please upload reports for the commit 502b03c to get more accurate results.

Files	Patch %	Lines
packages/dd-trace/src/config.js	89.47%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4369      +/-   ##
==========================================
- Coverage   92.64%   88.37%   -4.28%     
==========================================
  Files         116      249     +133     
  Lines        4173    10740    +6567     
  Branches       33       33              
==========================================
+ Hits         3866     9491    +5625     
- Misses        307     1249     +942     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zacharycmontoya]

LGTM