Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add aws xray context propagation #3898

Open
wants to merge 59 commits into
base: master
Choose a base branch
from
Open

feat: add aws xray context propagation #3898

wants to merge 59 commits into from
+388 −47

Conversation

wconti27
Copy link
Contributor

@wconti27 wconti27 commented Dec 20, 2023 •
edited
Loading

What does this PR do?

Add code to extract Trace Context Propagation from AWSTraceHeader, which is used by dd-trace-java to propagate context for some AWS services.

Motivation

Improving AWS propagation & dd-trace-js / dd-trace-java compatability.

Plugin Checklist

Additional Notes

Security

Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

wconti27 and others added 30 commits December 11, 2023 14:08
@wconti27
fix aws tests
2d39509
@wconti27
Merge branch 'master' into conti/fix-aws-sdk-tests
a3f31e7
@wconti27
fix kinesis timeouts
8f7f569
@wconti27
fix error
bbc5897
@wconti27
increase timeout
51fe166
@wconti27
try again
107e02b
@wconti27
no timeout test
af16096
@wconti27
add dsm for sns sqs and kinesis
aa84b7e
@wconti27
fix failing tests
1923d87
@wconti27
add debugging statemtn
b3b35b6
@wconti27
fix tests
c118fd3
@wconti27
fix sns tests
afcefb1
@wconti27
fix again
f014b2c
@wconti27
try env variable to enable
eb13676
@wconti27
fix lint
b0cb24b
@wconti27
Merge branch 'master' into conti/add-dsm-for-aws-services
6449e96
@wconti27
add message payload size tests for sns / kinesis
62aad55
@wconti27
add more payloadSize tests
43bb3f1
@wconti27
fix kinesis payload size
3f38244
@wconti27
fix kinesis tests
d8e7bff
@wconti27
Merge branch 'master' into conti/add-dsm-for-aws-services
2b88ce5
@wconti27
add context propagation to kinesis
564bff3
@wconti27
more tests
3a692aa
@wconti27
increase timeout
0e9010d
@wconti27
rewrite SQS to set DSM checkpoint for each message
c4a7d54
@wconti27
change payloadSize calculations
8fc0843
@wconti27
fix payload size error
8c5f653
@wconti27
use stream name for checkpoint if arn unavailable
73519f3
@wconti27
Merge branch 'conti/add-dsm-for-aws-services' into conti/add-context-…
5a11c04 
…extraction-aws-kinesis
@wconti27
add xray propagation
6e0d695
@wconti27 wconti27 self-assigned this Dec 17, 2024
@wconti27 wconti27 requested a review from vandonr December 17, 2024 21:11
@wconti27 wconti27 changed the title feat: add aws xray header context extraction feat: add aws xray context propagation Dec 19, 2024
@wconti27 wconti27 requested a review from a team as a code owner December 19, 2024 19:58
@tlhunter tlhunter mentioned this pull request Dec 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbonestell rbonestell rbonestell left review comments

@tlhunter tlhunter tlhunter left review comments

@rochdev rochdev rochdev requested changes

@Qard Qard Qard requested changes

@jbertran jbertran Awaiting requested review from jbertran jbertran was automatically assigned from DataDog/apm-framework-integrations-reviewers-js

@vandonr vandonr Awaiting requested review from vandonr

Requested changes must be addressed to merge this pull request.

Assignees

@wconti27 wconti27

Labels
semver-minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@wconti27 @rbonestell @jeebay @ConnorSinnott @jsonmorris @Qard @tlhunter @rochdev @vandonr