lint

DataDog · Jun 13, 2024 · ee28b92 · ee28b92
1 parent c3a5af3
commit ee28b92
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/packages/datadog-instrumentations/test/http.spec.js b/packages/datadog-instrumentations/test/http.spec.js
@@ -73,8 +73,7 @@ describe('client', () => {
 
         it('abortController is sent on startChannel', (done) => {
           http.get(url, (res) => {
-            res.on('data', () => {
-            })
+            res.on('data', () => {})
             res.on('end', () => {
               done()
             })
@@ -92,6 +91,7 @@ describe('client', () => {
           const cr = http.get(url, () => {
             done('Request should be blocked')
           })
+
           cr.on('error', (e) => {
             try {
               assert.instanceOf(e, Error)
@@ -115,6 +115,7 @@ describe('client', () => {
           const cr = http.get(url, () => {
             done('Request should be blocked')
           })
+
           cr.on('error', (e) => {
             try {
               assert.instanceOf(e, CustomError)
@@ -132,6 +133,7 @@ describe('client', () => {
           const cr = http.get(url, () => {
             done('Request should be blocked')
           })
+
           cr.on('error', () => {
             try {
               sinon.assert.calledOnce(errorChannelCb)
@@ -149,6 +151,7 @@ describe('client', () => {
           const cr = http.get(url, () => {
             done('Request should be blocked')
           })
+
           cr.on('error', () => {
             try {
               sinon.assert.called(endChannelCb)
@@ -167,6 +170,7 @@ describe('client', () => {
           const cr = http.get(url, () => {
             done('Request should be blocked')
           })
+
           cr.on('error', () => {
             try {
               // Necessary because the tracer makes extra requests to the agent

diff --git a/packages/dd-trace/src/appsec/blocking.js b/packages/dd-trace/src/appsec/blocking.js
@@ -122,8 +122,6 @@ function block (req, res, rootSpan, abortController, actionParameters) {
   responseBlockedSet.add(res)
 
   abortController?.abort()
-
-  // TODO add res in blocked weak set when response blocking is merged
 }
 
 function getBlockingAction (actions) {