Skip to content

Commit

Permalink
don't put user tracking tag when calling login tracking
Browse files Browse the repository at this point in the history
  • Loading branch information
simon-id committed Jan 17, 2025
1 parent c0ae70b commit 60789f4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
3 changes: 1 addition & 2 deletions packages/dd-trace/src/appsec/sdk/set_user.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ function setUserTags (user, rootSpan) {
for (const k of Object.keys(user)) {
rootSpan.setTag(`usr.${k}`, '' + user[k])
}

rootSpan.setTag('_dd.appsec.user.collection_mode', 'sdk')
}

function setUser (tracer, user) {
Expand All @@ -26,6 +24,7 @@ function setUser (tracer, user) {
}

setUserTags(user, rootSpan)
rootSpan.setTag('_dd.appsec.user.collection_mode', 'sdk')

const persistent = {}

Expand Down
1 change: 1 addition & 0 deletions packages/dd-trace/src/appsec/sdk/user_blocking.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ function checkUserAndSetUser (tracer, user) {
if (rootSpan) {
if (!rootSpan.context()._tags['usr.id']) {
setUserTags(user, rootSpan)
rootSpan.setTag('_dd.appsec.user.collection_mode', 'sdk')
}
} else {
log.warn('[ASM] Root span not available in isUserBlocked')
Expand Down

0 comments on commit 60789f4

Please sign in to comment.