Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(everything): merge main into v2 :salute_1: #2930

Draft
wants to merge 47 commits into
base: v2-dev
Choose a base branch
from

Commits on Sep 9, 2024

  1. all: upgrade minimum supported Go release to 1.22 (#2850)

    With Go 1.23 released on 2024-08-13, we drop support for Go 1.21. This
    means Go 1.22 is now our minimum supported Go release. Update our CI
    files to reflect our current supported Go versions, and remove pre-Go
    1.22 workarounds.
    
    In addition to the CI bumps, this PR changes/fixes a few things related to the upgrade:
    
    - Drops the old `rand` from the tracer, now that we can depend on `math/rand/v2`.
    - Uses `slices` in the appsec package.
    - The `TestWrapHandlerWithResourceNameNoRace` got a new data race. Specifically,
      by bumping our `go.mod` to 1.22, we get the new 1.22 ServeMux behavior internally.
      The 1.22 ServeMux modifies the Request, introducing a race with all the goroutines
      accessing/modifying the request concurrently. Fix it by giving each goroutine its own
      request. I verified that the test still catches the intended bug by reverting the fix from
      #2204 and verifying that the test fails.
    nsrip-dd authored Sep 9, 2024
    Configuration menu
    Copy the full SHA
    4b164f8 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. appsec: missing SQLi and LFI RC capabilities (#2851)

    Signed-off-by: Eliott Bouhana <[email protected]>
    eliottness authored Sep 10, 2024
    Configuration menu
    Copy the full SHA
    4574919 View commit details
    Browse the repository at this point in the history
  2. profiler: record Orchestrion, activation information (#2814)

    For tracking adoption of SSI for profiling, record whether the profiler
    was added using Orchestrion and how the profiler was activated,
    following the internal "Adding SSI information to profiles" RFC.
    nsrip-dd authored Sep 10, 2024
    Configuration menu
    Copy the full SHA
    0ffa615 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Configuration menu
    Copy the full SHA
    d1b31e8 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Configuration menu
    Copy the full SHA
    e1ca75f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    afcff94 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e081e4a View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. internal/civisibility/integrations/gotesting: add the `DD_CIVISIBILIT…

    …Y_ENABLED` kill switch environment variable (#2861)
    
    Co-authored-by: Juan Antonio Fernández de Alba <[email protected]>
    tonyredondo and juan-fernandez authored Sep 13, 2024
    Configuration menu
    Copy the full SHA
    07c4b72 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    660a6a2 View commit details
    Browse the repository at this point in the history
  3. internal/civisibility/integrations/gotesting: improve the isCiVisibil…

    …ityEnabled and enable reporting Code Coverage percentage. (#2866)
    tonyredondo authored Sep 13, 2024
    Configuration menu
    Copy the full SHA
    63f207d View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Configuration menu
    Copy the full SHA
    d9505b3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6d0e1b8 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Configuration menu
    Copy the full SHA
    1f0966d View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. internal/apps: Add two new apps (#2868)

    Co-authored-by: Nick Ripley <[email protected]>
    felixge and nsrip-dd authored Sep 18, 2024
    Configuration menu
    Copy the full SHA
    3646321 View commit details
    Browse the repository at this point in the history
  2. appsec: upgrade go-libddwaf v3.3.0 -> v3.4.0 (#2877)

    Signed-off-by: Eliott Bouhana <[email protected]>
    eliottness authored Sep 18, 2024
    Configuration menu
    Copy the full SHA
    b94c2c3 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Configuration menu
    Copy the full SHA
    054d19d View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Configuration menu
    Copy the full SHA
    8860b39 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. appsec: Suspicious Attacker Blocking (#2878)

    Signed-off-by: Eliott Bouhana <[email protected]>
    eliottness authored Sep 23, 2024
    Configuration menu
    Copy the full SHA
    ba18110 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Configuration menu
    Copy the full SHA
    7699f9e View commit details
    Browse the repository at this point in the history
  2. profiler: avoid metrics profile log noise when stopping profiling (#2865

    )
    
    The metrics profiler insisted on at least one second between collections
    for two reasons:
    
    - To avoid a division by zero because it was doing integer division to
      convert a time.Duration to seconds, which will truncate to 0, as a
      ratio in a subsequent computation
    - In case "a system clock issue causes time to run backwards"
    
    The profiler would report an error if less than one second elapsed
    between collections. In practice, this resulted in misleading error logs
    because it's entirely likely for profiling to be stopped less than a
    second after the last profile collection.
    
    The restriction was not really even needed. For one, we can just do
    floating-point division rather than integer division to avoid the
    truncation problem.
    
    Also, Go has had monotonic time support by default since 2017, added in
    Go 1.9, and time comparison operations including time.Time.Sub, work
    with respect to monotonic time. We shouldn't have any issues with
    negative periods. We can ensure the period is positive just as a
    defensive measure, and fail if it's negative since this may indicate a
    bug in the Go runtime if it's violating the monotonicity guarantees.
    
    Fixes #2863
    nsrip-dd authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    101d4da View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    eef52d3 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. profiler: suppress errors if the profiler is stopped (#2886)

    The fix in #2865 was intended to suppress spurious metrics profile
    errors when the profiler is stopped. It did so by relaxing the
    one-second duration constraint of the metrics profiler. However,
    the Windows system timer resolution is about 15 milliseconds (see
    https://learn.microsoft.com/en-us/windows-hardware/drivers/kernel/high-resolution-timers#controlling-timer-accuracy)
    This caused the metrics profile tests from #2865 to fail because the
    metrics profiler will likely be stopped in less than 15 milliseconds,
    meaning we'll see 0 duration between profile collection and log an
    error.
    
    This commit actually suppresses the error by checking whether the
    profiler was stopped (meaning interruptibleSleep was interrupted). If
    so, and if the metrics profiler returned an error, we instead return a
    sentinel error indicating that profiling was stopped. If we see that
    error, we just drop the profile and don't log an error. We won't upload
    the profile anyway. This way, we should only report an error from the
    metrics profiler if there is _actually_ a problem with the timer.
    nsrip-dd authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    ac73f9b View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. internal/datastreams: fix Processor goroutine leaks (#2880)

    Co-authored-by: Dario Castañé <[email protected]>
    ggambetti and darccio authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    bed7121 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    043dcd1 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Configuration menu
    Copy the full SHA
    82f0b8e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b0bb4c7 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Fix typo in README.md (#2898)

    fkmy authored Sep 30, 2024
    Configuration menu
    Copy the full SHA
    daa6823 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. appsec: Attacker Fingerprinting (#2899)

    Signed-off-by: Eliott Bouhana <[email protected]>
    eliottness authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    e5a17f2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0f6ba13 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Configuration menu
    Copy the full SHA
    438d47d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ef90025 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Configuration menu
    Copy the full SHA
    3b1e8a9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e90c07d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d3f686e View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. internal/civisibility: fixes the test parent status when the auto-ret…

    …ry feature ended up with a failed test and then a successful test. (#2910)
    tonyredondo authored Oct 4, 2024
    Configuration menu
    Copy the full SHA
    d50070a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    966abf2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2a34b15 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Configuration menu
    Copy the full SHA
    7704733 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. internal/telemetry: skip TestProductChange/profiler_start,_tracer_sta…

    …rt (#2887)
    
    This test case is has been flaky for a long time. Per our policy, skip
    it until we find a way to fix it.
    
    For #2688
    nsrip-dd authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    fc58656 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2f2854f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5b9a8af View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Configuration menu
    Copy the full SHA
    93311db View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. initial passthrough

    hannahkm committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    4f34a1c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2eeaab3 View commit details
    Browse the repository at this point in the history
  3. fix dyngo imports

    hannahkm committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    1de5adb View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ea693ee View commit details
    Browse the repository at this point in the history
  5. go mod tidy grpc

    hannahkm committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    fdd983b View commit details
    Browse the repository at this point in the history