Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrib/slog: clone record before calling Add #2929

Merged
merged 2 commits into from
Oct 16, 2024
Merged

contrib/slog: clone record before calling Add #2929

merged 2 commits into from
Oct 16, 2024
+46 −0

Commits on Oct 15, 2024

  1. contrib/slog: clone record before calling Add 

    Fix a bug that could manifest itself when a slog Record is modified
concurrently (A) with our handler.Handle implementation (B). If A
completes before B, then it might overwrite an attribute added by A.

Add test case demonstrating the issue.

Fixes #2918
    @felixge
    felixge committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    7362172 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Merge branch 'main' into gh-2918-slog-add-clone

    @felixge
    felixge authored Oct 16, 2024
    Configuration menu
    Copy the full SHA
    d4ac1ad View commit details
    Browse the repository at this point in the history