Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(contrib/confluent-kafka-go/kafka): extract tracing code #2894

Closed
wants to merge 5 commits into from

Conversation

darccio
Copy link
Member

@darccio darccio commented Sep 27, 2024

What does this PR do?

Refactoring tracing code for contrib/confluent-kafka-go/kafka to have an internal implementation usable by Orchestrion.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@darccio darccio requested review from a team as code owners September 27, 2024 07:53
@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Sep 27, 2024
@pr-commenter
Copy link

pr-commenter bot commented Sep 27, 2024

Benchmarks

Benchmark execution time: 2024-10-02 09:34:54

Comparing candidate commit 7bd514a in PR branch dario.castane/APPSEC-53286/refactor-tracing with baseline commit 82f0b8e in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 0 unstable metrics.

@darccio
Copy link
Member Author

darccio commented Oct 9, 2024

Closed in favour of #2907

@darccio darccio closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant