internal/appsec/emitter/waf: reduce rate limiting log spam #2888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ContextOperation.AddEvent method logs a warning if the ContextOperation's rate limit is hit. If there are a burst of calls to AddEvent, this means there will be a corresponding burst of logs. This happens for example when running BenchmarkGraphQL on the benchmarking platform. Only the first log is really useful.
BenchmarksBenchmark execution time: 2024-09-25 15:15:24 Comparing candidate commit c6dfc42 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 0 unstable metrics. scenario:BenchmarkInjectW3C-24
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
WIP: my first approach (add a "limited" field to the operation) was wrong
since the rate limiter is a global thing and each benchmark iteration is a new "operation"
The ContextOperation.AddEvent method logs a warning if the
ContextOperation's rate limit is hit. If there are a burst of calls to
AddEvent, this means there will be a corresponding burst of logs. This
happens for example when running BenchmarkGraphQL on the benchmarking
platform. Only the first log is really useful.
Motivation
Not sure how much it affects users. But I think it's making our microbenchmark
runs slow? That's where I noticed the log spam. Example pipeline