Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appsec: upgrade go-libddwaf v3.3.0 -> v3.4.0 #2877

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

eliottness
Copy link
Contributor

@eliottness eliottness commented Sep 18, 2024

What does this PR do?

  • Upgrade go-libddwaf
  • Setup RASP metrics

Motivation

APPSEC-54194

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@eliottness eliottness requested a review from a team as a code owner September 18, 2024 13:07
@pr-commenter
Copy link

pr-commenter bot commented Sep 18, 2024

Benchmarks

Benchmark execution time: 2024-09-18 13:37:10

Comparing candidate commit f7f515d in PR branch eliott.bouhana/APPSEC-54945 with baseline commit 3646321 in branch main.

Found 0 performance improvements and 3 performance regressions! Performance is the same for 56 metrics, 0 unstable metrics.

scenario:BenchmarkSampleWAFContext-24

  • 🟥 allocated_mem [+1.127KB; +1.133KB] or [+7.627%; +7.668%]
  • 🟥 allocations [+8; +8] or [+4.843%; +5.289%]

scenario:BenchmarkTracerAddSpans-24

  • 🟥 execution_time [+84.024ns; +100.976ns] or [+2.169%; +2.607%]

@eliottness eliottness merged commit b94c2c3 into main Sep 18, 2024
166 checks passed
@eliottness eliottness deleted the eliott.bouhana/APPSEC-54945 branch September 18, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants