-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contrib/grpc: attempt to fix flaky tests #2872
Conversation
- AppSec tests are occasionally receiving an unexpected `io.EOF` error from a gRPC stream send, which according to the documentation happens if the error does not originate from the client (and in those cases, blocking causes the error server-side) - Some tests were locally flaking due to expecting a certain count of security events being discovered, but this sometimes was not met due to the WAF timeout (this likely would not happen in CI, where we seront a higher-than-default timeout via environment) - Some other (non-AppSec) tests fail (possibly due to AppSec being there), but would not reproduce locally... so this PR replaces some calls to `require` with calls to `assert` to allow collection of more information about what's happened; and adds some new `assert` checks at key locations where errors could have been silently ignored previously.
BenchmarksBenchmark execution time: 2024-10-01 15:45:48 Comparing candidate commit 2af18ca in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics. |
/merge |
🚂 MergeQueue: waiting for PR to be ready This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
This merge request was unqueued If you need support, contact us on Slack #devflow! |
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
🚨 MergeQueue: This merge request is in error mergequeue build completed successfully, but the github api returned an error while merging the pr.
DetailsError: PUT https://api.github.com/repos/DataDog/dd-trace-go/pulls/2872/merge: 405 Waiting on code owner review from DataDog/apm-go and/or DataDog/apm-idm-go. 5 of 5 required status checks are expected. [] FullStacktrace: If you need support, contact us on Slack #devflow with those details! |
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
🚨 MergeQueue: This merge request is in error mergequeue build completed successfully, but the github api returned an error while merging the pr.
DetailsError: PUT https://api.github.com/repos/DataDog/dd-trace-go/pulls/2872/merge: 405 5 of 5 required status checks are expected. [] FullStacktrace: If you need support, contact us on Slack #devflow with those details! |
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
🚨 MergeQueue: This merge request is in error mergequeue build completed successfully, but the github api returned an error while merging the pr.
DetailsError: PUT https://api.github.com/repos/DataDog/dd-trace-go/pulls/2872/merge: 405 5 of 5 required status checks are expected. [] FullStacktrace: If you need support, contact us on Slack #devflow with those details! |
/merge |
🚂 MergeQueue: waiting for PR to be ready This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
What does this PR do?
io.EOF
error from a gRPC stream send, which according to the documentation happens if the error does not originate from the client (and in those cases, blocking causes the error server-side)require
with calls toassert
to allow collection of more information about what's happened; and adds some newassert
checks at key locations where errors could have been silently ignored previously.Reviewer's Checklist
Unsure? Have a question? Request a review!