Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/apps: move setup-smoke-test #2871

Merged
merged 2 commits into from
Sep 17, 2024
Merged

internal/apps: move setup-smoke-test #2871

merged 2 commits into from
Sep 17, 2024

Commits on Sep 17, 2024

  1. internal/apps: move setup-smoke-test 

    Move setup-smoke-test from internal/apps/setup-smoke-test to
internal/setup-smoke tests. This allows the other internal/apps to use
the latest version of go. We want this because these apps are often used
to test the latest new features which may depend on new go version. They
are also used for screenshots where we don't want to show an old go
version.

setup-smoke-test is serving a different purpose and needs to be tested
against the minimum version of Go that we support. So move it to a
separate location and give it its own go.mod file.
    @felixge
    felixge committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    e20d7ee View commit details
    Browse the repository at this point in the history

  2. internal/setup-smoke-test: use correct go directive in go.mod 

    See https://go.dev/play/p/KkX12rqpSwI
    @felixge
    felixge committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    83b630a View commit details
    Browse the repository at this point in the history