Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add aws credentials for system tests #2870

Merged
merged 6 commits into from
Sep 16, 2024

Conversation

wconti27
Copy link
Contributor

What does this PR do?

auth for system tests relying on creating aws resources

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@wconti27 wconti27 requested a review from a team as a code owner September 16, 2024 18:32
@wconti27 wconti27 self-assigned this Sep 16, 2024
@pr-commenter
Copy link

pr-commenter bot commented Sep 16, 2024

Benchmarks

Benchmark execution time: 2024-09-16 19:40:37

Comparing candidate commit f103dbf in PR branch conti/add-system-tests-aws-credentials with baseline commit d9505b3 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics.

@wconti27 wconti27 requested review from a team as code owners September 16, 2024 18:57
@mtoffl01 mtoffl01 merged commit 6d0e1b8 into main Sep 16, 2024
144 of 145 checks passed
@mtoffl01 mtoffl01 deleted the conti/add-system-tests-aws-credentials branch September 16, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants