Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2: migrate contribs to new instrumentation api (2) #2816

Merged
merged 12 commits into from
Aug 19, 2024

Conversation

rarguelloF
Copy link
Contributor

@rarguelloF rarguelloF commented Aug 13, 2024

What does this PR do?

Migrate contribs to new instrumentation api:

  • confluentinc/confluent-kafka-go
  • confluentinc/confluent-kafka-go.v2
  • database/sql
  • dimfeld/httptreemux.v5
  • elastic/go-elasticsearch.v6
  • emicklei/go-restful.v3
  • gin-gonic/gin
  • globalsign/mgo
  • go.mongodb.org/mongo-driver

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Aug 13, 2024
@rarguelloF rarguelloF changed the title Migrate contribs to new instrumentation api (2) v2: migrate contribs to new instrumentation api (2) Aug 19, 2024
@darccio darccio marked this pull request as ready for review August 19, 2024 13:07
@darccio darccio requested review from a team as code owners August 19, 2024 13:07
@darccio darccio merged commit adf58cf into dario.castane/contrib-api-v2 Aug 19, 2024
33 of 158 checks passed
@darccio darccio deleted the rarguelloF/update-contribs-2 branch August 19, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants