Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2: migrating contribs to the new Contrib API (urfave/negroni, valyala/fasthttp) #2813

Conversation

darccio
Copy link
Member

@darccio darccio commented Aug 8, 2024

What does this PR do?

Migrates a subset of the contribs to use the new contrib API. Each commit is a contrib, to simplify code review.

Motivation

Contrib API was created to split contribs as nested modules: see #2768

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Aug 8, 2024
@darccio darccio force-pushed the dario.castane/porting-contribs-to-contrib-api-1 branch from 879fb45 to 09a5ebe Compare August 9, 2024 15:16
Copy link
Contributor

@rarguelloF rarguelloF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@darccio darccio marked this pull request as ready for review August 12, 2024 09:52
@darccio darccio requested review from a team as code owners August 12, 2024 09:52
@darccio darccio changed the title v2: migrating contribs to the new Contrib API v2: migrating contribs to the new Contrib API (urfave/negroni, valyala/fasthttp) Aug 12, 2024
@darccio darccio merged commit cd879f6 into dario.castane/contrib-api-v2 Aug 12, 2024
4 of 157 checks passed
@darccio darccio deleted the dario.castane/porting-contribs-to-contrib-api-1 branch August 12, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants