Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddtrace/tracer: add uptrace/bun to telemetry's supported contribs #2810

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

darccio
Copy link
Member

@darccio darccio commented Aug 7, 2024

What does this PR do?

Adds uptrace/bun to our telemetry's supported contribs list.

Motivation

Making sure the integration is reported as imported when it's in use.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@darccio darccio requested a review from a team as a code owner August 7, 2024 08:00
@pr-commenter
Copy link

pr-commenter bot commented Aug 7, 2024

Benchmarks

Benchmark execution time: 2024-08-07 08:53:54

Comparing candidate commit 123aa69 in PR branch dario.castane/bun-telemetry with baseline commit 6674e13 in branch main.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 0 unstable metrics.

scenario:BenchmarkSetTagString-24

  • 🟩 execution_time [-5.456ns; -2.784ns] or [-4.667%; -2.381%]

@darccio darccio merged commit b5f3953 into main Aug 7, 2024
164 checks passed
@darccio darccio deleted the dario.castane/bun-telemetry branch August 7, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant