Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI VIsibility] Fix the source path for windows #2778

Merged
merged 6 commits into from
Jul 10, 2024

Conversation

liashenko
Copy link
Contributor

@liashenko liashenko commented Jul 8, 2024

What does this PR do?

Transform the source path from the windows represantion to the unix representation.

Implications:

Also, don't assert git commit details if the provider is github, because github doesn't provide those tags, example job:
https://github.com/DataDog/dd-trace-go/actions/runs/9853630340/job/27204586043

The final test for Windows: https://github.com/DataDog/dd-trace-go/actions/runs/9853630340

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@liashenko liashenko requested a review from a team as a code owner July 8, 2024 16:19
@pr-commenter
Copy link

pr-commenter bot commented Jul 8, 2024

Benchmarks

Benchmark execution time: 2024-07-10 09:08:13

Comparing candidate commit ba98f84 in PR branch andrii.liashenko/fix-windows-source-path with baseline commit 1a13250 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 1 unstable metrics.

@darccio darccio enabled auto-merge (squash) July 10, 2024 09:30
@darccio darccio merged commit 70b8a12 into main Jul 10, 2024
163 of 164 checks passed
@darccio darccio deleted the andrii.liashenko/fix-windows-source-path branch July 10, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants