-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
appsec: add SQLi RASP protection #2730
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, it overall looks good to me and I left 3 comments.
I would also love if we could add tests for all the different SQL queries (Exec, Update, etc.)
…n tags Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a refactor suggestion for the changes in contrib/database/sql
.
What does this PR do?
JIRA: APPSEC-52505
This change adds RASP protection for SQLi. If appsec is enabled, the WAF is run before executing a query, and the query only gets executed if the WAF doesn't yield a security event.
Motivation
This is part of the ASM exploit prevention effort.
Reviewer's Checklist
Unsure? Have a question? Request a review!