Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/net/http: harmonize benchmarks for v2 #2619

Merged
merged 5 commits into from
Mar 19, 2024

Conversation

darccio
Copy link
Member

@darccio darccio commented Mar 15, 2024

What does this PR do?

BenchmarkHttpServeTrace used the mocktracer instead of the real tracer.

Motivation

As in v2 we prefer to use the real tracer, although not completely applied, we found that we were measuring different implementations.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@darccio darccio requested a review from a team as a code owner March 15, 2024 16:34
@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Mar 15, 2024
@pr-commenter
Copy link

pr-commenter bot commented Mar 19, 2024

Benchmarks

Benchmark execution time: 2024-03-19 08:24:59

Comparing candidate commit f0df2d9 in PR branch dario.castane/AIT-9399/harmonize-benchmarks with baseline commit b4da5f8 in branch main.

Found 0 performance improvements and 3 performance regressions! Performance is the same for 37 metrics, 1 unstable metrics.

scenario:BenchmarkHttpServeTrace-24

  • 🟥 allocated_mem [+4.453KB; +4.475KB] or [+89.553%; +90.003%]
  • 🟥 allocations [+30; +30] or [+61.224%; +61.224%]
  • 🟥 execution_time [+6.351µs; +6.454µs] or [+62.950%; +63.980%]

@darccio darccio merged commit a1de76b into main Mar 19, 2024
157 checks passed
@darccio darccio deleted the dario.castane/AIT-9399/harmonize-benchmarks branch March 19, 2024 09:23
@darccio
Copy link
Member Author

darccio commented Mar 19, 2024

Using the real tracer instead of mocktracer results in higher metric values, as expected.

Thanks Diana!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants