Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/google.golang.org/grpc: fix flaky tests by removing arbitrary sleeps #2584

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

Julio-Guerra
Copy link
Contributor

What does this PR do?

Remove arbitrary calls to time.Sleep.
The test timeout will be enough to gate their exec time if they happen to fail.

Motivation

gRPC tests are extremely flaky on qemu arm64.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@Julio-Guerra Julio-Guerra requested a review from a team as a code owner February 28, 2024 14:24
@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Feb 28, 2024
@nsrip-dd
Copy link
Contributor

The test timeout will be enough to gate their exec time if they happen to fail.

As a bonus, if the whole test suite times out, you get a stack dump for all the goroutines. So if something was actually stuck the whole time you'll see it.

@pr-commenter
Copy link

pr-commenter bot commented Feb 28, 2024

Benchmarks

Benchmark execution time: 2024-02-28 16:47:39

Comparing candidate commit df52b39 in PR branch julio.guerra/remove-grpc-test-flakiness with baseline commit 8373eb9 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics.

@Julio-Guerra Julio-Guerra enabled auto-merge (squash) February 29, 2024 09:20
@Julio-Guerra Julio-Guerra merged commit 35aa850 into main Feb 29, 2024
157 checks passed
@Julio-Guerra Julio-Guerra deleted the julio.guerra/remove-grpc-test-flakiness branch February 29, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs ci
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants