Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: make container ID logic Linux-only #2452

Closed
wants to merge 1 commit into from

Conversation

nsrip-dd
Copy link
Contributor

What does this PR do?

cgroups are a Linux feature and all of our container ID logic is also
Linux-only. Move all of this behind a linux build tag.

Motivation

Fix the broken Windows build

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

cgroups are a Linux feature and all of our container ID logic is also
Linux-only. Move all of this behind a linux build tag.
@pr-commenter
Copy link

pr-commenter bot commented Dec 19, 2023

Benchmarks

Benchmark execution time: 2023-12-19 17:32:50

Comparing candidate commit ecdcd2c in PR branch nick.ripley/fix-entity-id with baseline commit 4ae528b in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics.

@nsrip-dd
Copy link
Contributor Author

Closing in favor of #2453

@nsrip-dd nsrip-dd closed this Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant