fix(contrib/net/http): avoid race condition on request value

DataDog · Sep 2, 2024 · bb94c3e · bb94c3e
1 parent 8c646bb
commit bb94c3e
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/contrib/net/http/http_test.go b/contrib/net/http/http_test.go
@@ -346,7 +346,6 @@ func TestServeMuxGo122Patterns(t *testing.T) {
 func TestWrapHandlerWithResourceNameNoRace(_ *testing.T) {
  mt := mocktracer.Start()
  defer mt.Stop()
- r := httptest.NewRequest("GET", "/", nil)
  resourceNamer := func(_ *http.Request) string {
  return "custom-resource-name"
  }
@@ -358,6 +357,7 @@ func TestWrapHandlerWithResourceNameNoRace(_ *testing.T) {
  for i := 0; i < 10; i++ {
  wg.Add(1)
  go func() {
+ r := httptest.NewRequest("GET", "/", nil)
  w := httptest.NewRecorder()
  defer wg.Done()
  mux.ServeHTTP(w, r)
@@ -369,14 +369,14 @@ func TestWrapHandlerWithResourceNameNoRace(_ *testing.T) {
 func TestServeMuxNoRace(_ *testing.T) {
  mt := mocktracer.Start()
  defer mt.Stop()
- r := httptest.NewRequest("GET", "/", nil)
  mux := NewServeMux()
  mux.Handle("/", http.NotFoundHandler())
 
  wg := sync.WaitGroup{}
  for i := 0; i < 10; i++ {
  wg.Add(1)
  go func() {
+ r := httptest.NewRequest("GET", "/", nil)
  w := httptest.NewRecorder()
  defer wg.Done()
  mux.ServeHTTP(w, r)